Suppress confirmation for delete and undo#49
Open
nfraprado wants to merge 1 commit intolharding:masterfrom
Open
Suppress confirmation for delete and undo#49nfraprado wants to merge 1 commit intolharding:masterfrom
nfraprado wants to merge 1 commit intolharding:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the delete and undo taskwarrior commands require confirmation by default and these commands are open through a (unidirectional) pipe stream in the background, when executing the undo or delete commands tasknc simply freezes, since the confirmation never happens.
This patch makes so that these commands don't require confirmation.
If there already is a convenient way to open a background process, write its output to the screen (to the pager for example), and then wait for input from the user to then pass it back to the background process, that would probably be better than simply suppressing the confirmation for these two commands. Otherwise, making these functions work without confirmation is at least better than letting the program freeze.